Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0e392a9d7003
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c671a4ece4b3
Choose a head ref
  • 10 commits
  • 11 files changed
  • 1 contributor

Commits on Apr 3, 2016

  1. [Truffle] Audit TimeNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    fa0625d View commit details

  2. [Truffle] Audit ProcNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    bda5a12 View commit details

  3. [Truffle] Audit BignumNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    16db193 View commit details

  4. [Truffle] Audit FixnumNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    c2e3c01 View commit details

  5. [Truffle] Audit FloatNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    4488062 View commit details

  6. [Truffle] Audit IntegerNodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    e5d7d09 View commit details

  7. [Truffle] Audit bool Nodes for unsafe.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    c8a7c15 View commit details

  8. [Truffle] Need to use define to set a new OM property.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    1
    Copy the full SHA
    13599c0 View commit details

  9. [Truffle] Extra slow tags.

    @chrisseaton
    chrisseaton committed Apr 3, 2016
    Copy the full SHA
    369734b View commit details

  10. [Truffle] Tag Hash spec that fails due to the rope table not differen… 

    …tiating encodings properly.
    @chrisseaton
    chrisseaton committed Apr 3, 2016
    1
    Copy the full SHA
    c671a4e View commit details
1 change: 1 addition & 0 deletions spec/truffle/tags/language/hash_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fails:Hash literal does not change encoding of literal string keys during creation
2 changes: 2 additions & 0 deletions spec/truffle/tags/language/string_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
slow:Ruby String literals with a magic frozen comment produce the same object each time
slow:Ruby String literals with a magic frozen comment produce the same object for literals with the same content
slow:Ruby String literals with a magic frozen comment produce the same object for literals with the same content in different files
slow:Ruby String literals with a magic frozen comment produce different objects for literals with the same content in different files if the other file doesn't have the comment
slow:Ruby String literals with a magic frozen comment produce different objects for literals with the same content in different files if they have different encodings
4 changes: 2 additions & 2 deletions truffle/src/main/java/org/jruby/truffle/core/bool/FalseClassNodes.java
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
@CoreClass(name = "FalseClass")
public abstract class FalseClassNodes {

@CoreMethod(unsafeNeedsAudit = true, names = "&", needsSelf = false, required = 1)
@CoreMethod(names = "&", needsSelf = false, required = 1)
public abstract static class AndNode extends UnaryCoreMethodNode {

public AndNode(RubyContext context, SourceSection sourceSection) {
@@ -35,7 +35,7 @@ public boolean and(Object other) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = { "|", "^" }, needsSelf = false, required = 1)
@CoreMethod(names = { "|", "^" }, needsSelf = false, required = 1)
public abstract static class OrXorNode extends UnaryCoreMethodNode {

public OrXorNode(RubyContext context, SourceSection sourceSection) {
6 changes: 3 additions & 3 deletions truffle/src/main/java/org/jruby/truffle/core/bool/TrueClassNodes.java
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
@CoreClass(name = "TrueClass")
public abstract class TrueClassNodes {

@CoreMethod(unsafeNeedsAudit = true, names = "&", needsSelf = false, required = 1)
@CoreMethod(names = "&", needsSelf = false, required = 1)
public abstract static class AndNode extends UnaryCoreMethodNode {

public AndNode(RubyContext context, SourceSection sourceSection) {
@@ -40,7 +40,7 @@ public boolean and(boolean other) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "|", needsSelf = false, required = 1)
@CoreMethod(names = "|", needsSelf = false, required = 1)
public abstract static class OrNode extends CoreMethodArrayArgumentsNode {

public OrNode(RubyContext context, SourceSection sourceSection) {
@@ -53,7 +53,7 @@ public boolean or(Object other) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "^", needsSelf = false, required = 1)
@CoreMethod(names = "^", needsSelf = false, required = 1)
public abstract static class XorNode extends UnaryCoreMethodNode {

public XorNode(RubyContext context, SourceSection sourceSection) {
56 changes: 28 additions & 28 deletions truffle/src/main/java/org/jruby/truffle/core/numeric/BignumNodes.java
View file
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ public Object fixnumOrBignum(BigInteger value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "-@")
@CoreMethod(names = "-@")
public abstract static class NegNode extends BignumCoreMethodNode {

public NegNode(RubyContext context, SourceSection sourceSection) {
@@ -67,7 +67,7 @@ public Object neg(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "+", required = 1)
@CoreMethod(names = "+", required = 1)
public abstract static class AddNode extends BignumCoreMethodNode {

public AddNode(RubyContext context, SourceSection sourceSection) {
@@ -91,7 +91,7 @@ public Object add(DynamicObject a, DynamicObject b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "-", required = 1)
@CoreMethod(names = "-", required = 1)
public abstract static class SubNode extends BignumCoreMethodNode {

public SubNode(RubyContext context, SourceSection sourceSection) {
@@ -115,7 +115,7 @@ public Object sub(DynamicObject a, DynamicObject b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "*", required = 1)
@CoreMethod(names = "*", required = 1)
public abstract static class MulNode extends BignumCoreMethodNode {

public MulNode(RubyContext context, SourceSection sourceSection) {
@@ -146,7 +146,7 @@ public Object mul(VirtualFrame frame, DynamicObject a, Object b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = {"/", "__slash__"}, required = 1)
@CoreMethod(names = {"/", "__slash__"}, required = 1)
public abstract static class DivNode extends BignumCoreMethodNode {

public DivNode(RubyContext context, SourceSection sourceSection) {
@@ -170,7 +170,7 @@ public Object div(DynamicObject a, DynamicObject b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = {"%", "modulo"}, required = 1)
@CoreMethod(names = {"%", "modulo"}, required = 1)
public abstract static class ModNode extends BignumCoreMethodNode {

public ModNode(RubyContext context, SourceSection sourceSection) {
@@ -209,7 +209,7 @@ public Object mod(VirtualFrame frame, DynamicObject a, Object b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "<", required = 1)
@CoreMethod(names = "<", required = 1)
public abstract static class LessNode extends CoreMethodArrayArgumentsNode {

public LessNode(RubyContext context, SourceSection sourceSection) {
@@ -242,7 +242,7 @@ public Object lessCoerced(VirtualFrame frame, DynamicObject a, Object b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "<=", required = 1)
@CoreMethod(names = "<=", required = 1)
public abstract static class LessEqualNode extends CoreMethodArrayArgumentsNode {

public LessEqualNode(RubyContext context, SourceSection sourceSection) {
@@ -274,7 +274,7 @@ public Object lessEqualCoerced(VirtualFrame frame, DynamicObject a, Object b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = {"==", "eql?"}, required = 1)
@CoreMethod(names = {"==", "eql?"}, required = 1)
public abstract static class EqualNode extends CoreMethodArrayArgumentsNode {

@Child private BooleanCastNode booleanCastNode;
@@ -322,7 +322,7 @@ public boolean equal(VirtualFrame frame, DynamicObject a, DynamicObject b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = ">=", required = 1)
@CoreMethod(names = ">=", required = 1)
public abstract static class GreaterEqualNode extends CoreMethodArrayArgumentsNode {

public GreaterEqualNode(RubyContext context, SourceSection sourceSection) {
@@ -354,7 +354,7 @@ public Object greaterEqualCoerced(VirtualFrame frame, DynamicObject a, Object b)
}
}

@CoreMethod(unsafeNeedsAudit = true, names = ">", required = 1)
@CoreMethod(names = ">", required = 1)
public abstract static class GreaterNode extends CoreMethodArrayArgumentsNode {

public GreaterNode(RubyContext context, SourceSection sourceSection) {
@@ -386,7 +386,7 @@ public Object greaterCoerced(VirtualFrame frame, DynamicObject a, Object b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "~")
@CoreMethod(names = "~")
public abstract static class ComplementNode extends BignumCoreMethodNode {

public ComplementNode(RubyContext context, SourceSection sourceSection) {
@@ -400,7 +400,7 @@ public Object complement(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "&", required = 1)
@CoreMethod(names = "&", required = 1)
public abstract static class BitAndNode extends BignumCoreMethodNode {

public BitAndNode(RubyContext context, SourceSection sourceSection) {
@@ -418,7 +418,7 @@ public Object bitAnd(DynamicObject a, DynamicObject b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "|", required = 1)
@CoreMethod(names = "|", required = 1)
public abstract static class BitOrNode extends BignumCoreMethodNode {

public BitOrNode(RubyContext context, SourceSection sourceSection) {
@@ -436,7 +436,7 @@ public Object bitOr(DynamicObject a, DynamicObject b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "^", required = 1)
@CoreMethod(names = "^", required = 1)
public abstract static class BitXOrNode extends BignumCoreMethodNode {

public BitXOrNode(RubyContext context, SourceSection sourceSection) {
@@ -454,7 +454,7 @@ public Object bitXOr(DynamicObject a, DynamicObject b) {
}
}

@CoreMethod(unsafeNeedsAudit = true, names = "<<", required = 1, lowerFixnumParameters = 0)
@CoreMethod(names = "<<", required = 1, lowerFixnumParameters = 0)
public abstract static class LeftShiftNode extends BignumCoreMethodNode {

private final BranchProfile bLessThanZero = BranchProfile.create();
@@ -475,7 +475,7 @@ public Object leftShift(DynamicObject a, int b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = ">>", required = 1, lowerFixnumParameters = 0)
@CoreMethod(names = ">>", required = 1, lowerFixnumParameters = 0)
public abstract static class RightShiftNode extends BignumCoreMethodNode {

private final BranchProfile bLessThanZero = BranchProfile.create();
@@ -496,7 +496,7 @@ public Object leftShift(DynamicObject a, int b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = { "abs", "magnitude" })
@CoreMethod(names = { "abs", "magnitude" })
public abstract static class AbsNode extends BignumCoreMethodNode {

public AbsNode(RubyContext context, SourceSection sourceSection) {
@@ -510,7 +510,7 @@ public Object abs(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "bit_length")
@CoreMethod(names = "bit_length")
public abstract static class BitLengthNode extends CoreMethodArrayArgumentsNode {

public BitLengthNode(RubyContext context, SourceSection sourceSection) {
@@ -524,7 +524,7 @@ public int bitLength(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "coerce", required = 1)
@CoreMethod(names = "coerce", required = 1)
public abstract static class CoerceNode extends CoreMethodArrayArgumentsNode {

public CoerceNode(RubyContext context, SourceSection sourceSection) {
@@ -561,7 +561,7 @@ public DynamicObject coerce(DynamicObject a, DynamicObject b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "divmod", required = 1)
@CoreMethod(names = "divmod", required = 1)
public abstract static class DivModNode extends CoreMethodArrayArgumentsNode {

@Child private GeneralDivModNode divModNode;
@@ -588,7 +588,7 @@ public DynamicObject divMod(DynamicObject a, DynamicObject b) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "even?")
@CoreMethod(names = "even?")
public abstract static class EvenNode extends BignumCoreMethodNode {

public EvenNode(RubyContext context, SourceSection sourceSection) {
@@ -603,7 +603,7 @@ public boolean even(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "hash")
@CoreMethod(names = "hash")
public abstract static class HashNode extends CoreMethodArrayArgumentsNode {

public HashNode(RubyContext context, SourceSection sourceSection) {
@@ -617,7 +617,7 @@ public int hash(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "odd?")
@CoreMethod(names = "odd?")
public abstract static class OddNode extends BignumCoreMethodNode {

public OddNode(RubyContext context, SourceSection sourceSection) {
@@ -632,7 +632,7 @@ public boolean odd(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "size")
@CoreMethod(names = "size")
public abstract static class SizeNode extends CoreMethodArrayArgumentsNode {

public SizeNode(RubyContext context, SourceSection sourceSection) {
@@ -646,7 +646,7 @@ public int size(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "to_f")
@CoreMethod(names = "to_f")
public abstract static class ToFNode extends CoreMethodArrayArgumentsNode {

public ToFNode(RubyContext context, SourceSection sourceSection) {
@@ -660,7 +660,7 @@ public double toF(DynamicObject value) {

}

@CoreMethod(unsafeNeedsAudit = true, names = {"to_s", "inspect"}, optional = 1)
@CoreMethod(names = {"to_s", "inspect"}, optional = 1)
public abstract static class ToSNode extends CoreMethodArrayArgumentsNode {

public ToSNode(RubyContext context, SourceSection sourceSection) {
@@ -686,7 +686,7 @@ public DynamicObject toS(DynamicObject value, int base) {

}

@CoreMethod(unsafeNeedsAudit = true, names = "allocate", constructor = true)
@CoreMethod(names = "allocate", constructor = true)
public abstract static class AllocateNode extends UnaryCoreMethodNode {

public AllocateNode(RubyContext context, SourceSection sourceSection) {
Loading