It's easier to just do DOIT_CONFIG = config.get('DOIT_CONFIG', {})

Indeed it is. I have this habit of writing all of my code like I'm preparing to show it in my CS1 course.

Don’t put empty lines at the beginnings of functions.

Removed. I guess I didn't clean up properly after removing some debug prints.

Wouldn’t it be nicer to let users’ DOIT_CONFIG override this? Some people might want to override our opinionated reporter choice.

if self.quiet:
    DOIT_CONFIG = {…}  # from original code
else:
    DOIT_CONFIG = {…}

DOIT_CONFIG.update(config.get('DOIT_CONFIG', {}))

We also need to pop DOIT_CONFIG out of the config dict in nikola.py (we don’t need to save it anywhere though) so self.configured works correctly.

updating the dictionary as you suggest makes sense to me. I hadn't thought that you guys would want anyone to override what you had coded in there.

Since DOIT_CONFIG may or may not be in config. Why don't I just check and pop it out of config in the load_tasks function?

So, it seems like going back to the original and adding this one line:

        DOIT_CONFIG.update(config.pop('DOIT_CONFIG', {}))

would do what you want.

load_tasks is called after configuration is passed to the site object. We can’t do that.

So then we can't just pop it out and throw it away in __init__ It has to stay somewhere so that load_tasks can get to it.

Then pop it out in Nikola.__init__ and use nikola._doit_config here. (besides, where does config come from in this code?)

config is declared as a global on line 58 of __main__ and then populated on line 114 in main after loading conf.py

        config = conf.__dict__

ah, a global. That’s evil.

Still, you can just get it from self.nikola if you pop it out there.

I tried:

AttributeError: 'Nikola' object has no attribute '_doit_config'

I'm guessing you were suggesting I create _doit_config

Yes, that’s what I was suggesting. Add after nikola.py line 287:

        self._doit_config = config.pop('DOIT_CONFIG', {})

No need to change it, but I tend to leave the last commas in this sort of things because it makes the diff better the next time something is added :-)

(It also lets the next person just type in their changes without having to care about adding a comma.)