Replace unicode apostrophes with ascii #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you do it again? Codebase changed meanwhile :) |
charles-cooper
force-pushed
the
master
branch
2 times, most recently
from
6d2d910
to
b960b24
Compare
Dropped down to src and executed
```
find . -type f -exec sed -i "s/‘/'/g" {} +
find . -type f -exec sed -i "s/’/'/g" {} +
```
charles-cooper
changed the title
|
whoops, this fell off my radar. should be good to go! |
|
Here is the new reincarnation #1377 |
|
Fixed in NixOS/rfcs@690b7ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped down to src and executed
Fixes #532