Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urbanterror: 4.3.1 -> 4.3.2 #24654

Merged
merged 1 commit into from Apr 5, 2017
Merged

urbanterror: 4.3.1 -> 4.3.2 #24654

merged 1 commit into from Apr 5, 2017

Conversation

2chilled
Copy link
Contributor

@2chilled 2chilled commented Apr 5, 2017

Motivation for this change

Upgrade

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

})
];

buildInputs = [ unzip SDL mesa openal curl libXxf86vm ];
sourceRoot = "ioq3-for-UrbanTerror-4-release-4.3.1";
sourceRoot = "ioq3-for-UrbanTerror-4-release-4.3.2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better?

sourceRoot = "ioq3-for-UrbanTerror-4-release-${version}";

Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rasendubi rasendubi merged commit c3df8bd into NixOS:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants