Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fvwm module: init; now fvwm can be used as an xserver.windowManager #24651

Merged
merged 1 commit into from Apr 6, 2017

Conversation

edanaher
Copy link
Contributor

@edanaher edanaher commented Apr 5, 2017

Motivation for this change

#24435. Also I've been using fvwm as my window manager for years, but now that I understand nixos, I should really contribute it back.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

BTW, would you like to become FVWM maintainer in nixpkgs? It currently doesn't have any :(

@edanaher edanaher mentioned this pull request Apr 6, 2017
7 tasks
@rasendubi rasendubi merged commit b8e71f2 into NixOS:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants