Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules/tasks/filesystems.nix: Skip bindfs FS check #24657

Closed
wants to merge 2 commits into from
Closed

nixos/modules/tasks/filesystems.nix: Skip bindfs FS check #24657

wants to merge 2 commits into from

Conversation

0xABAB
Copy link
Contributor

@0xABAB 0xABAB commented Apr 5, 2017

Motivation for this change

A bindfs is a trivial FS.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

@mention-bot
Copy link

@0xABAB, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @Profpatsch to be potential reviewers.

@Profpatsch Profpatsch self-requested a review April 5, 2017 20:13
Profpatsch
Profpatsch requested changes Apr 5, 2017
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a description on what this PR fixes to the commit message, please?

@0xABAB
Skip filesystem check for bindfs
d431dd9 
Bindfs (FUSE) provides a pseudo-filesystem and as such does not benefit from a file system check.
@Profpatsch
Copy link
Member

Ah, you have two commits now. It should be possible to combine them with

git reset HEAD~1
git add  nixos/modules/tasks/filesystems.nix
git commit --amend

though it will drop your extended message on the first command.

Otherwise use git rebase --interactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch requested changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xABAB @mention-bot @Profpatsch @Janik-Haag