openshot-qt: 2.2.0 -> 2.3.1 #24868
openshot-qt: 2.2.0 -> 2.3.1 #24868
Conversation
|
@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tohl, @AndersonTorres and @bjornfor to be potential reviewers. |
|
I simplified the wrapper code a little bit, but loading the xcb plugins remains an error on master. https://gist.github.com/Mic92/7c73214090560627222040abc9a48545 looks like version mismatch, but i cannot tell why. |
| @@ -23,12 +25,9 @@ stdenv.mkDerivation rec { | |||
| installPhase = '' | |||
There was a problem hiding this comment.
If you override installPhase, the first line must be runHook preInstall and the last line must be runHook postInstall.
| wrapQtProgram $out/bin/openshot-qt \ | ||
| --prefix PYTHONPATH : "$(toPythonPath $out):$(toPythonPath ${libopenshot}):$(toPythonPath ${python3Packages.pyqt5}):$(toPythonPath ${python3Packages.sip}):$(toPythonPath ${python3Packages.httplib2}):$(toPythonPath ${python3Packages.pyzmq}):$PYTHONPATH" | ||
|
|
||
| makeQtWrapper $(toPythonPath $out)/launch.py $out/bin/openshot-qt \ |
There was a problem hiding this comment.
It is not a good idea to call makeQtWrapper until preFixup.
It looks to me like a linker error rather than a version mismatch. (Version mismatches always result in a segmentation fault.) It may be related to the issues I commented on. |
|
Looks like using |
|
Open dialogs are now working in my environment. |
|
Should this be picked to NixOS 17.03? |
Motivation for this change
New upstream release (also trying to convince Bryan Lunduke to talk about Nix :-P)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)When I ran this on my system (NixOS 17.03), it worked fine there, but when I tried to run the version I successfully built against the Nixpkgs master branch, I got an error about how Qt couldn't find the XCB plugin. I'm not sure if this would be an issue if I was running on NixOS unstable channel or master.