added macOS compatibility to portmidi-3.17 #24855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plumps, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @wkennington and @fpletz to be potential reviewers. |
plumps
changed the title
LnL7
suggested changes
Apr 13, 2017
| url = "https://raw.github.com/Rogentos/argent-gentoo/master/media-libs/" | ||
| + "portmidi/files/portmidi-217-cmake-libdir-java-opts.patch"; | ||
| sha256 = "1jbjwan61iqq9fqfpq2a4fd30k3clg7a6j0gfgsw87r8c76kqf6h"; | ||
| }); | ||
| }) ++ optional stdenv.isDarwin ./darwin.patch; |
There was a problem hiding this comment.
Looks like you forgot to commit this file
error: getting status of ‘/nix/store/hljk2wdrny0rzdx9krl1zrqh2disv0ha-git-export/pkgs/development/libraries/portmidi/darwin.patch’: No such file or directory
There was a problem hiding this comment.
you are so right o.O., fixed that
LnL7
reviewed
Apr 18, 2017
| substituteInPlace ./${path}/CMakeLists.txt --replace "CoreMIDI.framework" \ | ||
| "${CoreMIDI}/Library/Frameworks/CoreMIDI.framework" | ||
| substituteInPlace ./${path}/CMakeLists.txt --replace "CoreServices.framework" \ | ||
| "${CoreServices}/Library/Frameworks/CoreServices.framework" |
There was a problem hiding this comment.
This seems to replace the same things as the patch, why not replace it directly here?
There was a problem hiding this comment.
To clarify, I think something like this should make most of the patch file redundant.
substituteInPlace pm_dylib/CMakeLists.txt \
--replace '${FRAMEWORK_PATH}/CoreAudio.framework' "${CoreAudio}/Library/Frameworks/CoreAudio.framework"
...
|
@plumps are you still working on this? |
|
@c0bw3b nope |
|
@NixOS/darwin-maintainers does someone feel like resuming/completing this or should we close for now? |
|
Stalled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed portmidi for pygame. Haven't changed a thing about the missing java builds.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)