gce/create-gce.sh: rewrite using nix-shell shebang and bash #24869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows to run the script without being the same directory - nix-shell install google-cloud-sdk - some shellcheck cleanups and scripting best practice
edolstra
reviewed
Apr 13, 2017
| set -euo pipefail | ||
|
|
||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | ||
| NIXPKGS_ROOT="$DIR/../../../../" |
There was a problem hiding this comment.
I think it's better to simply use nixpkgs from $NIX_PATH, similar to nixos/maintainers/scripts/ec2/create-amis.sh. I often need to tweak create-amis.sh temporarily (e.g. upload to one region first) but I do want to ensure that the Nixpkgs used to build the image corresponds cleanly to a channel, rather than my working directory. So I do NIX_PATH=nixpkgs=channel:nixos-17.03 ./nixos/maintainers/scripts/ec2/create-amis.sh.
Mic92
commented
Apr 13, 2017
| -A config.system.build.googleComputeImage \ | ||
| --argstr system x86_64-linux \ | ||
| -o gce \ | ||
| --option extra-binary-caches https://hydra.nixos.org \ |
There was a problem hiding this comment.
I swapped http with https here, to make building an image remote a bit more trustworthy.
There was a problem hiding this comment.
Isn't this option legacy, AFAIK hydra.nixos.org doesn't serve anything anymore.
this allows NIX_PATH to be overwritten to build a different release
benley
pushed a commit
to benley/nixpkgs
that referenced
this pull request
May 23, 2017
) * google-cloud-sdk: 150.0.0 -> 151.0.0 - gce/create-gce.sh: rewrite using nix-shell shebang and bash - allows to run the script without being the same directory - nix-shell install google-cloud-sdk - some shellcheck cleanups and scripting best practice - gce/create-gce.sh: do not clobber NIX_PATH: this allows NIX_PATH to be overwritten to build a different release - gce/create-gce.sh: remove legacy hydra option (cherry picked from commit 73c8797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)