acme: Add "domain" option to separate domain from name #24854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NixOS#24731. (cherry picked from commit e3559c2) This is useful on servers like mine, which often prefer to stay on stable releases. Since there's no impact if you're not using the new option, this should be safe to pull in.
|
@edanaher, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @abbradar and @bobvanderlinden to be potential reviewers. |
|
@fpletz - You merged this into master; is there any reason why it can't go into 17.03? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24731.
(cherry picked from commit e3559c2)
This is useful on servers like mine, which often prefer to stay on stable
releases. Since there's no impact if you're not using the new option, this
should be safe to pull in.
Motivation for this change
See the issue for overall description, but as noted in the commit message, it seems reasonable to add to stable so it can be used on servers running 17.03 without any extra work.
(This is my first PR for a release branch; hopefully it's reasonable ;) )
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)