Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digikam: add video support through libqtav #24866

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Issue #24426

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jraygauthier, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @cillianderoiste and @urkud to be potential reviewers.

@jraygauthier
Copy link
Member Author

@the-kenny

@the-kenny
Copy link
Contributor

the-kenny commented Apr 17, 2017

Sorry, I was on vacation around easter. LGTM, build is running right now on my machine. Will merge if it succeeds & works.

@the-kenny the-kenny merged commit 383706f into NixOS:master Apr 17, 2017
@jraygauthier
Copy link
Member Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants