Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conan: init at 0.21.2 #24865

Merged
merged 4 commits into from Apr 13, 2017
Merged

conan: init at 0.21.2 #24865

merged 4 commits into from Apr 13, 2017

Conversation

mucaho
Copy link
Contributor

@mucaho mucaho commented Apr 13, 2017 •
edited

Motivation for this change

Conan is a cross-platform package manager for C/C++.
@igsha has already laid out most of the work for this change (see his conan branch). It was just missing a little bit, so here it goes 👍
Additionally this PR includes a commit from still unmerged PR #24131, since conan also depends on pythonPackages.distro that is initialized there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
    • this is aliased as nix.useChroot so I hope I have tested it with command below
  • Tested using buildtime sandboxing (nix-build . --option build-use-chroot true -A conan)
  • Tested using runtime sandboxing (nix-shell -I nixpkgs=. --pure -p conan)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • tested by building starting tutorial
    • you need gcc, gnumake and cmake to build the tutorial, but they are not runtime dependencies
  • Fits CONTRIBUTING.md.

@mucaho
pythonPackages.distro: init 1.0.3
80c295f 
- tested on darwin
- tested on nixos
@mention-bot
Copy link

@mucaho, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@mucaho mucaho changed the title Conan conan: init at 0.21.2 Apr 13, 2017
@Mic92 Mic92 merged commit 300c59c into NixOS:master Apr 13, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 13, 2017

Thanks!

@mucaho mucaho deleted the conan branch April 13, 2017 11:27
@mucaho
Copy link
Contributor Author

mucaho commented Apr 13, 2017 •
edited

(Edited)
Np, although it doesn't build on all architectures on hydra 😢

Builds on x86_64, but doesn't on i686 due to a cached failure. The linked reproduce script builds fine, probably because I'm on 64 bit.
Will the conan package be still available to build from source from the nixpkgs-unstable channel for 32bit users?

More specifically, it's because the transitive dependency python2.7-astroid-1.4.9 (required by conan's direct dependency python2.7-pylint-1.6.5) doesn't pass all tests.
There is an updated version astroid-1.5.1 available from github.

So I'm not sure what should be done further:

  • change conan's or astroids platform to x86_64
  • disable doCheck for the astroid package
  • update astroid to new version
running install tests
............s..................................ssssssssss........s........................................................................s.....................................sssssssssssssssss.........sss.s...............................ss....s....................................s...............s..sss/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_protocols.py:165: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  node.root().locals['__all__'] = [node.value]
........ss....ssssss...........sss.F/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:59: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a1 = module.locals['a'][0]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:60: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a2 = module.locals['a'][1]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:61: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a3 = module.locals['a'][2]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:62: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a4 = module.locals['a'][3]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:63: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a5 = module.locals['a'][4]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:64: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  a6 = module.locals['a'][5]
./tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:39: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  xass1 = module.locals['x'][0]
./tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:87: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  f1 = module.locals['exclusive_func2'][0]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:88: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  f2 = module.locals['exclusive_func2'][1]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:89: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  f3 = module.locals['exclusive_func2'][2]
/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_utils.py:90: PendingDeprecationWarning: locals is deprecated and will be removed in astroid 2.0, use the function 'get_locals()' instead.
  f4 = module.locals['exclusive_func2'][3]
...............................................
======================================================================
FAIL: test_from_imports (astroid.tests.test_unittest_brain.SixBrainTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/nix-build-python2.7-astroid-1.4.9.drv-0/astroid-1.4.9/astroid/tests/test_unittest_brain.py", line 276, in test_from_imports
    self.assertIsInstance(inferred, nodes.ClassDef)
AssertionError: YES is not an instance of <class 'astroid.scoped_nodes.ClassDef'>

----------------------------------------------------------------------
Ran 388 tests in 4.300s

FAILED (failures=1, skipped=53)
builder for ‘/nix/store/s1rj91jaxj45968scl6whxijdpf3f1sd-python2.7-astroid-1.4.9.drv’ failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mucaho @mention-bot @Mic92