qt4: enable gtk2 by default #24861
Merged
qt4: enable gtk2 by default #24861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's perhaps not clear whether to have qt4 depend on gtk2 by default (during runtime). EDIT: currently the added closure size would be ~33 MB. BTW, gtk2 doesn't need schemas to display file dialogs, I think, so I expect we won't need any wrapping. |
|
Perhaps /cc @ttuegel, too. |
|
@vcunat Indeed, we don't need any wrapping. My point was that Qt 5 currently depends on GTK 3 for theming (sad but necessary), so we may as well have Qt 4 depend on GTK 2. I don't think there is any other way to make this work D: |
|
Yes, I see no other easy and correct way. We don't yet have a good solution for plugin-like dependencies. |
|
I'll merge this in few days unless anyone objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Analogous to Qt 5 currently. I split GNOME dependencies (we don't need them for most cases). Qt 4 applications look so much better now on XFCE!
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)