-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(peazy) enumerator backports for 1.7 #4563
Conversation
@kares thanks for backporting/picking back to 1.7. My only concern with this work is adding 2.x semantics but I can see (I only checked seek) was added in 1.9.x. So long as compat is cool bombs away! |
@enebo thanks, I did check the docs. |
@kares yeah I assumed you checked to see if the methods existed in 1.9. I was partially mentioning semantics of the methods themselves but I stated that perhaps in too general of a way. |
👍 Looks good. |
ok, semantics isn't 100% MRI compatible like on 9K and since this is simply a back-port it will do the same. |
@kares yeah I was just asking for due dilligence on whether there was some 2.0ish behavior making back to 1.9. So as long as you thought about it I definitely trust your judgement. |
@enebo great thanks. I am grateful as I am never 100% sure either on these. I'll squash and merge than. |
~ cherry-picked from master, so that feed and some others are available
resolves #1571