Add explicit dependencies on several tools we need #1345
Conversation
I left unzip and git implicit, but made sure they had loud comments next to them.
| @@ -11,6 +11,7 @@ with import <nixpkgs> {}; | |||
| pkgconfig sqlite libsodium boehmgc | |||
| docbook5 docbook5_xsl | |||
| autoconf-archive | |||
| lsof # Used by the garbage collector to determine what's in use | |||
There was a problem hiding this comment.
The duplication between here and release.nix made me uncomfortable but they do seem pretty duplicatey already.
|
What if Nix is compiled on different machine than it's used? Or is the purpose to hardcode nix store paths for those tools (autotools is magic)? |
|
@domenkozar yes, it would include store paths for those tools whenever built by Nix, and they'd thus end up in the runtime closure of Nix (a good thing IMO). And if someone builds it on a non-Nix system we'll just embed non-store paths and nothing is lost. @edolstra any thoughts? I saw that since I submitted this PR, you already did Still curious how to do things like |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
|
@copumpkin I think it's unfortunate the bot was closing pull requests. Are you still interested in working on this? The addressed issues are still hitting Nix beginners. |
I left unzip and git implicit, but made sure they had loud comments next to them.
Should fix #1335, #1328, and #1234
Also, regarding the autoconf,