Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-generic-builder: Expose haskell and system build inputs. #24710

Closed
wants to merge 1 commit into from

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Apr 7, 2017

This can be used to build envs for building haskell packages that are
more complicated than the default env currently exported, e.g. a
single composite env that can be used to build multiple packages.

This can be used to build envs for building haskell packages that are
more complicated than the default env currently exported, e.g. a
single composite env that can be used to build multiple packages.
@shlevy shlevy requested a review from peti April 7, 2017 14:17
@mention-bot
Copy link

@shlevy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @expipiplus1 to be potential reviewers.

@shlevy
Copy link
Member Author

shlevy commented Apr 7, 2017

@peti this is basically the work you reverted before, but as far as I can tell there's still no good way to do this.

@shlevy
Copy link
Member Author

shlevy commented Apr 30, 2017

@peti ping

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the notion of the generic builder exporting its inputs as output. It feels wrong and unnecessary considering the fact that those values are readily available without running the generic builder, i.e. one can simply override any package's mkDerivation with a function that composes and returns the desired haskellBuildInput, and such a function could live in haskell.lib and be re-usable for all kind of purposes --- including re-use by the generic builder. IMHO, that'd be a far superior approach.

@shlevy
Copy link
Member Author

shlevy commented May 1, 2017

Ah, that's a good idea, thanks.

@shlevy shlevy closed this May 1, 2017
@shlevy shlevy deleted the haskell-expose-haskell-deps branch May 1, 2017 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants