Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robomongo: 0.8.4 -> 0.9.0 #24705

Merged
merged 3 commits into from Apr 8, 2017
Merged

robomongo: 0.8.4 -> 0.9.0 #24705

merged 3 commits into from Apr 8, 2017

Conversation

emanueleperuffo
Copy link
Contributor

@emanueleperuffo emanueleperuffo commented Apr 7, 2017

Motivation for this change

Support for mongodb 3.x and wiredTiger engine.
See this issue https://github.com/Studio3T/robomongo/issues/960

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Not sure about test using sandboxing. I did this:

nix-build -A robomongo --option nix.useSandbox true

@mention-bot
Copy link

@emanueleperuffo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fignuts, @zimbatm and @zraexy to be potential reviewers.


src = fetchurl {
url = https://github.com/paralect/robomongo/archive/v0.8.4.tar.gz;
sha256 = "199fb08701wrw3ky7gcqyvb3z4027qjcqdnzrx5y7yi3rb4gvkzc";
url = "https://download.robomongo.org/0.9.0/linux/robomongo-0.9.0-linux-x86_64-0786489.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue, when building from source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tried to build version 0.9.0 from source since they provide a binary with all the necessary libraries in a tar.gz.

@aristidb aristidb merged commit cafd9c9 into NixOS:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants