Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: remove duplicate wrapperDir PATH addition #24703

Merged
merged 1 commit into from Apr 9, 2017
Merged

nixos: remove duplicate wrapperDir PATH addition #24703

merged 1 commit into from Apr 9, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2017

Motivation for this change

Duplicate wrapperDir PATH addition should be removed. Correct PATH addition is already defined here.

Things done

@mention-bot
Copy link

@tk-ecotelecom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oxij, @edolstra and @zimbatm to be potential reviewers.

@@ -168,9 +168,6 @@ in

${cfg.extraInit}

# The setuid/setcap wrappers override other bin directories.
export PATH="${config.security.wrapperDir}:$PATH"

# ~/bin if it exists overrides other bin directories.
export PATH="$HOME/bin:$PATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace export PATH="$HOME/bin:$PATH" with export PATH=$HOME/bin:$PATH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xABAB, That's unrelated to this patch. But if in a separate commit, I don't care. (Although my personal preference is to quote too much than too little.)

@oxij
Copy link
Member

oxij commented Apr 7, 2017 via email

@0xABAB
Copy link
Contributor

0xABAB commented Apr 8, 2017

@oxij What would happen if there was a space? (This is a rhetorical question, since you clearly have no idea how to write a shell script. Oh, and for the love of $DEITY, please test your code before you say more stupid things.)

@oxij
Copy link
Member

oxij commented Apr 8, 2017 via email

@0xABAB
Copy link
Contributor

0xABAB commented Apr 8, 2017

@oxij So, now you are saying that tooling which is as old as UNIX itself has changed semantics as opposed to the simpler explanation that in 1998 you didn't know what you were doing (something which is ostensibly true in 2017)? Bold, very bold.

@oxij
Copy link
Member

oxij commented Apr 9, 2017 via email

@0xABAB
Copy link
Contributor

0xABAB commented Apr 9, 2017

@oxij You should learn to recognize a superior force when you meet one.

From 1996: http://www.fnal.gov/docs/products/bash/bashref.htm, we read:

If value is not given, the variable is assigned the null string. All values undergo tilde expansion, parameter and variable expansion, command substitution, arithmetic expansion, and quote removal (detailed below). If the variable has its `-i' attribute set (see the description of the declare builtin in section Bash Builtin Commands), then value is subject to arithmetic expansion even if the $((...)) syntax does not appear (see section Arithmetic Expansion). Word splitting is not performed, with the exception of "$@" as explained below. Filename expansion is not performed.

Sure, I know that bash semantics changes over time, but you are just using that to hide your mistake from other ignorant people who do not understand this is irrelevant in this case.

I understand why autoconf does what it does; you apparently do not. I am not going to give another free lecture, btw.

When will you figure out that it's better to just not say anything, because of the difficulty you have with producing true statements?

@joachifm joachifm merged commit 42e1314 into NixOS:master Apr 9, 2017
@joachifm
Copy link
Contributor

joachifm commented Apr 9, 2017

@tk-ecotelecom thank you

@bjornfor
Copy link
Contributor

bjornfor commented Apr 9, 2017

0xABAB: Why do you respond like that? I'm perceiving your message as both angry and arrogant. It seems completely uncalled for.

@NeQuissimus
Copy link
Member

Jeez... Let's all be adults and move on...

Chill pill

@0xABAB
Copy link
Contributor

0xABAB commented Apr 9, 2017

@bjornfor Persistent insistence on sharing incompetence can elicit such a response.

@oxij
Copy link
Member

oxij commented Apr 13, 2017 via email

@NixOS NixOS locked and limited conversation to collaborators Apr 13, 2017
@ghost ghost deleted the fix-wrapper-path branch May 19, 2017 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants