New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos: remove duplicate wrapperDir
PATH addition
#24703
Conversation
@@ -168,9 +168,6 @@ in | |||
|
|||
${cfg.extraInit} | |||
|
|||
# The setuid/setcap wrappers override other bin directories. | |||
export PATH="${config.security.wrapperDir}:$PATH" | |||
|
|||
# ~/bin if it exists overrides other bin directories. | |||
export PATH="$HOME/bin:$PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace export PATH="$HOME/bin:$PATH"
with export PATH=$HOME/bin:$PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xABAB, That's unrelated to this patch. But if in a separate commit, I don't care. (Although my personal preference is to quote too much than too little.)
Bjørn Forsman <notifications@github.com> writes:
@0xABAB, That's unrelated to this patch. But if in a separate commit, I don't care. (Although my personal preference is to quote too much than too little.)
Agreed, leave the quotes, someone might have a space in $HOME, it's not prohibited.
|
@oxij What would happen if there was a space? (This is a rhetorical question, since you clearly have no idea how to write a shell script. Oh, and for the love of $DEITY, please test your code before you say more stupid things.) |
0xABAB <notifications@github.com> writes:
@oxij What would happen if there was a space? (This is a rhetorical question, since you clearly have no idea how to write a shell script. Oh, and for the love of $DEITY, please *test* your code before you say more stupid things.)
I expected it to perform normal substitution like
X="echo test"
$X
does in bash. But it doesn't. It most certainly did the last time I
checked in 1998 on RedHat. I'm not complaining, though. F*ck
substitutions like that.
|
@oxij So, now you are saying that tooling which is as old as UNIX itself has changed semantics as opposed to the simpler explanation that in 1998 you didn't know what you were doing (something which is ostensibly true in 2017)? Bold, very bold. |
0xABAB <notifications@github.com> writes:
@oxij So, now you are saying that tooling which is as old as UNIX
itself has changed semantics as opposed to the simpler explanation
... except, its not. And bash does change semantics. Why do you think
autoconf scripts "check shell", i.e. run bash snippets? To check and
work-around old bash behavior.
that in 1998 you didn't know what you were doing (something which is
ostensibly true in 2017)? Bold, very bold.
Maybe, maybe not. I got bitten by not having enough quotes in bash
enough times to prefer adding more than strictly required. Now I'm
mildly optimistic about the future of variable assignment in bash.
But how exactly does it hurt to have quotes in there?
Either way, does this has anything to do with this PR?
Can we stop the bikeshedding now and merge?
|
@oxij You should learn to recognize a superior force when you meet one. From 1996: http://www.fnal.gov/docs/products/bash/bashref.htm, we read:
Sure, I know that bash semantics changes over time, but you are just using that to hide your mistake from other ignorant people who do not understand this is irrelevant in this case. I understand why autoconf does what it does; you apparently do not. I am not going to give another free lecture, btw. When will you figure out that it's better to just not say anything, because of the difficulty you have with producing true statements? |
@tk-ecotelecom thank you |
0xABAB: Why do you respond like that? I'm perceiving your message as both angry and arrogant. It seems completely uncalled for. |
@bjornfor Persistent insistence on sharing incompetence can elicit such a response. |
0xABAB <notifications@github.com> writes:
@oxij You should learn to recognize a superior force when you meet one.
Yes, master!
>> So, now you are saying that tooling which is as old as UNIX itself has
>> changed semantics
Sure, I know that bash semantics changes over time
Okay. I forgive.
>> that in 1998 you didn't know what you were doing (something which is
>> ostensibly true in 2017)? Bold, very bold.
> Maybe, maybe not.
Wasn't okay? No forgiveness?
> But how exactly does it hurt to have quotes in there?
[a wall funny text that dosn't answer the question]
You are always welcome to 4chan!
|
Motivation for this change
Duplicate
wrapperDir
PATH addition should be removed. Correct PATH addition is already defined here.Things done