hugo: 0.18.1 -> 0.19 #24238
Closed
hugo: 0.18.1 -> 0.19 #24238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pradeepchhetri, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schneefux and @kamilchm to be potential reviewers. |
matthiasbeyer
approved these changes
Mar 23, 2017
schneefux
suggested changes
Mar 24, 2017
There was a problem hiding this comment.
Build fails with
go/src/github.com/spf13/hugo/helpers/general.go:256: cannot use jwalterweatherman.FEEDBACK (type jwalterweatherman.Feedback) as type logPrinter in field value:
jwalterweatherman.Feedback does not implement logPrinter (Println method has pointer receiver)
github.com/spf13/hugo/utils
# github.com/spf13/hugo/utils
go/src/github.com/spf13/hugo/utils/utils.go:24: undefined: jwalterweatherman.Notepad
go/src/github.com/spf13/hugo/utils/utils.go:39: undefined: jwalterweatherman.Notepad
github.com/spf13/hugo/helpers
# github.com/spf13/hugo/helpers
go/src/github.com/spf13/hugo/helpers/general.go:256: cannot use jwalterweatherman.FEEDBACK (type jwalterweatherman.Feedback) as type logPrinter in field value:
jwalterweatherman.Feedback does not implement logPrinter (Println method has pointer receiver)
builder for ‘/nix/store/7gc5374gl2iz0djyafjz2c8pyyms3v7f-hugo-0.19.drv’ failed with exit code 12
error: build of ‘/nix/store/7gc5374gl2iz0djyafjz2c8pyyms3v7f-hugo-0.19.drv’ failedon my machine
|
We're already on 0.20.6 on master, not sure what happened here but this is obsolete nevertheless. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)