stog: init at 0.17.0 #24241
Closed
stog: init at 0.17.0 #24241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
requested changes
Mar 23, 2017
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "stog${version}"; |
There was a problem hiding this comment.
You may want to add a dash ‘-’ between stog and its version.
|
|
||
| createFindlibDestdir = true; | ||
|
|
||
| patches = ./install.patch; |
There was a problem hiding this comment.
The patches attribute is expected to be a list, I think.
| patches = ./install.patch; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "XML documents and web site compiler."; |
There was a problem hiding this comment.
Descriptions are preferred without a final period.
| then throw "xtmpl not supported for ocaml ${ocaml.version}" | ||
| else | ||
| stdenv.mkDerivation rec { | ||
| name = "xtmpl${version}"; |
|
@vbgl: thanks for the review, I updated tho PR accordingly
|
vbgl
reviewed
Mar 24, 2017
| }; | ||
|
|
||
| buildInputs = [ ocaml ocf ptime uutf uri ppx_blob xtmpl ocaml_lwt higlo camlp4 ]; | ||
| propagatedBuildInputs = [ findlib omd ]; |
There was a problem hiding this comment.
How did you chose this list of propagated inputs? The stog library needs some more.
|
Indeed, I just picked the one needed for the binary. I'll propagate
the ocaml modules needed by the library as well.
|
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and adds other needed packages)
Tested on NixOS (and with
nox-review).