Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 73a85de298a0
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 30c7678e8f6f
Choose a head ref
  • 5 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 23, 2017

  1. qt5.qtwebengine: patch more library paths

    Adapted from chromium derivation. Fixes qutebrowser crash.
    
    (cherry picked from commit a7a858a)
    abbradar committed Mar 23, 2017
    Copy the full SHA
    9cc4b2f View commit details
  2. nss: propagate nspr

    (cherry picked from commit 1715e36)
    abbradar committed Mar 23, 2017
    Copy the full SHA
    64d4593 View commit details
  3. srtp: build as shared library

    (cherry picked from commit 5a04d38)
    abbradar committed Mar 23, 2017
    Copy the full SHA
    15fdfa9 View commit details
  4. qt5.qtwebengine: use system libraries where possible

    Fixes #23987.
    
    (cherry picked from commit 040b86a)
    abbradar committed Mar 23, 2017
    Copy the full SHA
    d5bd98e View commit details
  5. qt5.qtwebengine: add proprietary codecs support

    (cherry picked from commit 3a948e6)
    abbradar committed Mar 23, 2017
    Copy the full SHA
    30c7678 View commit details
Showing with 27 additions and 14 deletions.
  1. +3 −1 pkgs/development/libraries/nss/default.nix
  2. +22 −13 pkgs/development/libraries/qt-5/5.7/qtwebengine/default.nix
  3. +2 −0 pkgs/development/libraries/srtp/default.nix
4 changes: 3 additions & 1 deletion pkgs/development/libraries/nss/default.nix
Original file line number Diff line number Diff line change
@@ -16,7 +16,9 @@ in stdenv.mkDerivation rec {
sha256 = "1wrx2ig6yvgywjs25hzy4szgml21hwhd7ds0ghyfybhkiq7lyg6x";
};

buildInputs = [ nspr perl zlib sqlite ];
buildInputs = [ perl zlib sqlite ];

propagatedBuildInputs = [ nspr ];

prePatch = ''
xz -d < ${nssPEM} | patch -p1
35 changes: 22 additions & 13 deletions pkgs/development/libraries/qt-5/5.7/qtwebengine/default.nix
Original file line number Diff line number Diff line change
@@ -2,16 +2,19 @@

, xlibs, libXcursor, libXScrnSaver, libXrandr, libXtst
, fontconfig, freetype, harfbuzz, icu, dbus
, zlib, libjpeg, libpng, libtiff
, zlib, minizip, libjpeg, libpng, libtiff, libwebp, libopus
, jsoncpp, protobuf, libvpx, srtp, snappy, nss, libevent
, alsaLib
, libcap
, pciutils
, systemd

, bison, flex, git, which, gperf
, coreutils
, pkgconfig, python2
, enableProprietaryCodecs ? true

, stdenv # lib.optional, needsPax
, lib, stdenv # lib.optional, needsPax
}:

qtSubmodule {
@@ -32,27 +35,33 @@ qtSubmodule {
substituteInPlace ./src/3rdparty/chromium/v8/build/standalone.gypi \
--replace /bin/echo ${coreutils}/bin/echo
# fix default SSL bundle location
sed -i -e 's,/cert.pem,/certs/ca-bundle.crt,' src/3rdparty/chromium/third_party/boringssl/src/crypto/x509/x509_def.c
# Fix library paths
sed -i \
-e "s,QLibraryInfo::location(QLibraryInfo::DataPath),QLatin1String(\"$out\"),g" \
-e "s,QLibraryInfo::location(QLibraryInfo::TranslationsPath),QLatin1String(\"$out/translations\"),g" \
-e "s,QLibraryInfo::location(QLibraryInfo::LibraryExecutablesPath),QLatin1String(\"$out/libexec\"),g" \
src/core/web_engine_library_info.cpp
configureFlags+="\
-plugindir $out/lib/qt5/plugins \
-importdir $out/lib/qt5/imports \
-qmldir $out/lib/qt5/qml \
-docdir $out/share/doc/qt5"
sed -i -e '/lib_loader.*Load/s!"\(libudev\.so\)!"${systemd.lib}/lib/\1!' \
src/3rdparty/chromium/device/udev_linux/udev?_loader.cc
sed -i -e '/libpci_loader.*Load/s!"\(libpci\.so\)!"${pciutils}/lib/\1!' \
src/3rdparty/chromium/gpu/config/gpu_info_collector_linux.cc
'';

qmakeFlags = lib.optional enableProprietaryCodecs "WEBENGINE_CONFIG+=use_proprietary_codecs";

propagatedBuildInputs = [
dbus zlib alsaLib
dbus zlib minizip alsaLib snappy nss protobuf jsoncpp libevent

# Image formats
libjpeg libpng libtiff
libjpeg libpng libtiff libwebp

# Video formats
srtp libvpx

# Audio formats
alsaLib libopus

# Text rendering
fontconfig freetype harfbuzz icu
@@ -64,7 +73,7 @@ qtSubmodule {
libcap
pciutils
];
patches = stdenv.lib.optional stdenv.needsPax ./qtwebengine-paxmark-mksnapshot.patch;
patches = lib.optional stdenv.needsPax ./qtwebengine-paxmark-mksnapshot.patch;
postInstall = ''
cat > $out/libexec/qt.conf <<EOF
[Paths]
2 changes: 2 additions & 0 deletions pkgs/development/libraries/srtp/default.nix
Original file line number Diff line number Diff line change
@@ -23,6 +23,8 @@ stdenv.mkDerivation rec {
"--disable-debug"
] ++ optional (openssl != null) "--enable-openssl";

buildFlags = [ "shared_library" ];

postInstall = ''
rm -rf $out/bin
'';