Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra: 0.17.6 -> 2.0.1 #24644

Merged
merged 1 commit into from Apr 5, 2017
Merged

Conversation

calvertvl
Copy link
Contributor

Package bump.

Requires build against newer ffmpeg (3.2.x instead of 3.1.x)
because of new symbols:
FF_PROFILE_H264_MULTIVIEW_HIGH
FF_PROFILE_H264_STEREO_HIGH

Motivation for this change

0.17.6 was EOL in late 2016, this is the latest version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Dependent packages (which compile and appear to work but I do not use) are:
winswitch
ib-controller

Known issues (common to 0.17.6):

  • Running with Xdummy does not work because xorg cannot find the dummy driver - is there a way to specify the video drivers that the provided xorgserver derivation uses?

Requires build against newer ffmpeg (3.2.x instead of 3.1.x)
because of new symbols:
FF_PROFILE_H264_MULTIVIEW_HIGH
FF_PROFILE_H264_STEREO_HIGH
@mention-bot
Copy link

@calvertvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @volth, @bjornfor and @edolstra to be potential reviewers.

@bjornfor
Copy link
Contributor

bjornfor commented Apr 5, 2017

Cc @offlinehacker

@offlinehacker
Copy link
Contributor

I was testing with 2.0-rc1, in my local nixpkgs, and it forks ok, with all use cases i have(xpra as X display manager, pulseaudio, mmap, vsock,...) and i assume they didn't break anything in this patch, so i'm ok with merging.

@offlinehacker
Copy link
Contributor

offlinehacker commented Apr 5, 2017

Btw xdummy works ok for me, look into xpra.nix nixos module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants