Stage-2 cleanup #24645
Merged
Stage-2 cleanup #24645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way `set -x` is set early
|
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @fpletz and @rickynils to be potential reviewers. |
danbst
reviewed
Apr 5, 2017
| @@ -71,22 +71,17 @@ fi | |||
|
|
|||
|
|
|||
| # Provide a /etc/mtab. | |||
| mkdir -m 0755 -p /etc | |||
| test -e /etc/fstab || touch /etc/fstab # to shut up mount | |||
| test -e /etc/fstab || install -D /dev/null /etc/fstab # to shut up mount | |||
There was a problem hiding this comment.
this is bad IMO. Better be explicit in creating /etc, it isn't used only for /etc/fstab
danbst
reviewed
Apr 5, 2017
| mkdir -m 0755 -p /etc/nixos | ||
| mkdir -m 0755 -p /var{,log,lib,db} /nix/var /etc/nixos/ \ | ||
| /run/lock /home /bin # for the /bin/sh symlink | ||
| install -m 0700 -d /root |
There was a problem hiding this comment.
any reason of using install over chmod here?
There was a problem hiding this comment.
because it will both create a directory or chown existing an one.
edolstra
reviewed
Apr 5, 2017
| mkdir -m 0755 -p /etc/nixos | ||
| mkdir -m 0755 -p /var{,log,lib,db} /nix/var /etc/nixos/ \ | ||
| /run/lock /home /bin # for the /bin/sh symlink | ||
| install -m 0700 -d /root |
There was a problem hiding this comment.
Because it will both create a directory or chown existing an one.
|
I would merge this soon, if there are no more concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)