New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsharp: init at 4.1.7 #24385
fsharp: init at 4.1.7 #24385
Conversation
This seems to break a handful of .Net packages. |
@vbgl, I am trying to find my way around in this - this is my first attempt to contribute, so there will be some bumps. Currently I am trying to find a way to extend Is there any way to flag this PR as incomplete? Or should I just close it and re-open whenever I feel it is more ready (though I kind of like the feedback I get from Travis CI)? |
I can mark it as wip |
Thanks! |
@kuznero just ping me when you want WIP removed |
@ndowens I think I have completed the task... in terms of building and installing F# 4.1.7. Though I cannot understand why it fails. It seems the build script is trying to build some dotNet packages with using this F# and it fails (but I noticed that it is using old version of mono - 4.0.x). Please advice how should I proceed from now. |
@copumpkin, @edef1c, please review this PR. I am pretty new to Nix(OS) community but work with dotNet ecosystem on a daily basis and would really like to get new F# compiler in. |
It feels that there is something irrelevant that fails in that build now |
This breaks F*, at least on darwin; the logs ends with:
|
I ended up introducing new package |
@ndowens I think it is ok to remove WIP tag now. |
It all should be done now. |
@kuznero I don't know much about .NET or F#, but just for your future reference,
you don't need the |
@copumpkin thanks for the tip, I am happy to learn more about nix. |
|
||
ln -s ${dotnetPackages.FsCheck262}/lib/dotnet/FsCheck packages/FsCheck.2.6.2 | ||
ln -s ${dotnetPackages.FSharpCompilerTools}/lib/dotnet/FSharp.Compiler.Tools packages/FSharp.Compiler.Tools.4.1.4 | ||
ln -s ${dotnetPackages.FSharpCore}/lib/dotnet/FSharp.Core/ packages/FSharp.Core.4.0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be easier for future updates to leave version number here?
ln -s ${dotnetPackages.FSharpCore}/lib/dotnet/FSharp.Core/ packages/FSharp.Core.${dotnetPackages.FSharpCore.version}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it might not be critical as FSharp.Core
of that particular version is used to build a new version of the same library that this package is then producing. So, in a sense when all the versions of NuGet dependencies are listed like this in just one place, it is easier to handle when one will need to upgrade for example.
Please let me know if I misunderstood your comment.
Build F# with default mono version Introduce separate fsharp41 packages
Motivation for this change
Introduce new language features with new version of F# compiler v4.1.
Build was tested like so on NixOS 17.03:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)