Use Trajectory in BodyCentredBodyDirectionDynamicFrame #1296
+104
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 29, 2017
| BodyCentredBodyDirectionDynamicFrame( | ||
| not_null<Ephemeris<InertialFrame> const*> const ephemeris, | ||
| not_null<MassiveBody const*> const primary, | ||
| not_null<MassiveBody const*> const secondary) |
There was a problem hiding this comment.
I preferred the previous formatting...
| DegreesOfFreedom<InertialFrame> const secondary_degrees_of_freedom = | ||
| secondary_trajectory_->EvaluateDegreesOfFreedom(t); | ||
|
|
||
| Vector<Acceleration, InertialFrame> const primary_acceleration = | ||
| ephemeris_->ComputeGravitationalAccelerationOnMassiveBody(primary_, t); | ||
| // TODO(egg): eventually we want to add the intrinsic acceleration here. | ||
| primary_ == nullptr |
There was a problem hiding this comment.
This (rather ugly) test could be avoided by having another functor compute_gravitational_acceleration_on_primary and setting it in the constructor.
There was a problem hiding this comment.
The arguments differ, in the second case we pass the position.
eggrobin
force-pushed
the
evaluate-discrete
branch
from
815f44e to
31078a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No intrinsic accelerations for now.