CB-230: Migrate Moderation Log code off the ORM. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferbncode
force-pushed
the
migrate-moderation-log
branch
from
a157957
to
03bc4e0
Compare
gentlecat
suggested changes
Apr 13, 2017
critiquebrainz/db/moderation_log.py
Outdated
| reason (str): Reason for blocking a user or hiding a review. | ||
| """ | ||
| if not review_id and not user_id: | ||
| raise TypeError("No review ID or user ID specified.") |
There was a problem hiding this comment.
ValueError would be more appropriate here and below.
critiquebrainz/db/moderation_log.py
Outdated
|
|
||
| def create(*, admin_id, review_id=None, user_id=None, | ||
| action, reason): | ||
| """Log blocking a user or hiding a review with IDs. |
There was a problem hiding this comment.
blocking a user or hiding a review
This doesn't have to be so specific. You could just say something like "Make a record in the moderation log."
critiquebrainz/db/moderation_log.py
Outdated
| logs = result.fetchall() | ||
| logs = [dict(log) for log in logs] | ||
| if logs: | ||
| for log in logs: |
There was a problem hiding this comment.
Instead of having two loops you could just do something like
logs = []
for log in result.fetchall():
...
ferbncode
force-pushed
the
migrate-moderation-log
branch
from
6c63ff5
to
ad38d95
Compare
gentlecat
suggested changes
Apr 14, 2017
critiquebrainz/db/moderation_log.py
Outdated
| if not review_id and not user_id: | ||
| raise ValueError("No review ID or user ID specified.") | ||
| if action != ACTION_BLOCK_USER and action != ACTION_HIDE_REVIEW: | ||
| raise TypeError("Please specify a valid action.") |
There was a problem hiding this comment.
Same problem with exception. Make sure to use the right class everywhere.
gentlecat
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions
moderation_log.createandmoderation_log.list_logsand corresponding tests for managing logs.