Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purple-facebook: 0.9.0 -> 0.9.3 #24739

Merged
merged 1 commit into from Apr 8, 2017
Merged

purple-facebook: 0.9.0 -> 0.9.3 #24739

merged 1 commit into from Apr 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2017 •
edited by ghost

Motivation for this change

Fixes Null value for $.viewer.message_threads.sync_sequence_id error preventing the plugin from working.

Confirmed that it builds, runs and fixes the issue.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@tjg1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 and @davorb to be potential reviewers.

@davorb
Copy link
Contributor

davorb commented Apr 8, 2017

Looks good.

@Mic92 Mic92 merged commit cc95da5 into NixOS:master Apr 8, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 8, 2017

I also backported this one, because the protocol broke: 645137c

@ghost
Copy link
Author

ghost commented Apr 8, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mention-bot @davorb @Mic92