Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fadeExclude description. #24724

Merged
merged 2 commits into from Apr 8, 2017
Merged

Fix fadeExclude description. #24724

merged 2 commits into from Apr 8, 2017

Conversation

iclanzan
Copy link
Contributor

@iclanzan iclanzan commented Apr 7, 2017 •
edited

Motivation for this change

The description for the fadeExclude options was wrongly mentioning shadows.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@iclanzan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rnhmjoj and @joachifm to be potential reviewers.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 7, 2017

Thanks you. Can you also fix the typo in shadowExclude?

@iclanzan
Copy link
Contributor Author

iclanzan commented Apr 8, 2017

Done.

@joachifm joachifm merged commit b41dd2f into NixOS:master Apr 8, 2017
@joachifm
Copy link
Contributor

joachifm commented Apr 8, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iclanzan @mention-bot @rnhmjoj @joachifm @Janik-Haag