hunspellDicts: add spanish dictionaries. #24720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails with hash mismatch on darwin. I expect it's not actually a platform problem, but suggests the hash might be unstable. Can you investigate? |
|
@aristdb I can't reproduce. Can you please give me more details? Which hash is failing for you? |
|
Just see the failed build log from Travis-CI: https://travis-ci.org/NixOS/nixpkgs/jobs/219807159#L693 |
|
@k0001 also, maybe |
This reverts commit cf4f91f, which removed all of the spanish dictionaries. These dictionaries were previously part of the “Red IRIS” project, but they are now part of the “Recursos Linguísticos Abiertos del Español” project. Additionally, this cleans up the implementation of all the Hunspell dictionaries, since the supposedly internal `mkDict` function was either overspecialized or overgeneralized. Now we don't try to abstract beyond what makes sense to be abstracted.
|
Checking the hashes, they were correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cf4f91f, which
removed all of the spanish dictionaries. These dictionaries were
previously part of the “Red IRIS” project, but they are now part of the
“Recursos Linguísticos Abiertos del Español” project.
Additionally, this cleans up the implementation of all the Hunspell
dictionaries, since the supposedly internal
mkDictfunction was eitheroverspecialized or overgeneralized. Now we don't try to abstract beyond
what makes sense to be abstracted.
Motivation for this change
Spanish Hunspell dictionaries were removed from nixpkgs, this brings them back.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)