buku: 2.8 -> 2.9 #24730
buku: 2.8 -> 2.9 #24730
Conversation
|
@infinisil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @edwtjo and @zimbatm to be potential reviewers. |
| ]; | ||
| propagatedBuildInputs = [ beautifulsoup4 ]; |
There was a problem hiding this comment.
According to https://github.com/jarun/Buku/blob/master/setup.py#L34 these are all run-time dependencies. That's why I have updated this commit. Does this also needs to be fixed in 17.03?
There was a problem hiding this comment.
Before this commit it didn't work in 17.03, so yes it does. It's my first PR here, sorry if I missed something :)
| @@ -31,7 +32,7 @@ with pythonPackages; buildPythonApplication rec { | |||
| homepage = https://github.com/jarun/Buku; | |||
| license = licenses.gpl3; | |||
| platforms = platforms.linux; | |||
| maintainers = with maintainers; [ matthiasbeyer ]; | |||
| maintainers = with maintainers; [ matthiasbeyer infinisil ]; | |||
There was a problem hiding this comment.
Hey! You don't need to put yourself into the maintainers array, if you don't want to! If you want to, yes, feel free, I appreciate that! But I want you to know that you do not have to! 😄
There was a problem hiding this comment.
Well I'd like this package to stay up-to-date, so I guess that's okay 😉. I just got up and running with my NixOS installation and I also intend to contribute much more in the future :D
There was a problem hiding this comment.
Awesome! Then welcome to the club!
Motivation for this change
Updated the package while fixing the executable not running due to missing python modules.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)