hy: 0.11.1 -> 0.12.1 #24735
Merged
hy: 0.11.1 -> 0.12.1 #24735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed build inputs up a little while bumping version
|
So the appdir packages should be also in propagatedBuildInputs in release-17.03? |
|
Yeah the appdirs package should be fixed in 17.03 as well. How would I go about updating/fixing that? Can I just submit a pull request against the release-17.03 branch? The path forward for making changes to a release branch isn't entirely clear to me. |
|
yes, just make a pull request against release-17.03 and refer to 106214a. Usually we just cherry-pick commits from master, but in this case the commit also contains a major version upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed build inputs up a little while bumping version
Motivation for this change
Hylang had a version bump and my original package was broken. appdirs is needed as a propogated build input. Honestly not sure how I messed that up last time, since I had a working version. I think I had done some work that I hadn't commited
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)