Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cups-dymo: patch upstream for cups 2.2 #24392

Merged
merged 1 commit into from Mar 29, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Mar 27, 2017

Motivation for this change

dymo cups driver do not build with the latest version of cups on nixpkgs-unstable. This is due to missing explicit includes. This PR creates a patch until the issue is fixed with upstream (created support ticket). PR is related to #24339

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@makefu
Copy link
Contributor Author

makefu commented Mar 29, 2017

CI dies because of some weird nox errors.

@vcunat
Copy link
Member

vcunat commented Mar 29, 2017

So this does actually work against current master, i.e. without that cups-config fixup?

@vcunat
Copy link
Member

vcunat commented Mar 29, 2017

Well, it builds now at least, and merging it to master directly can't worsen the cups-dymo situation in there...

@vcunat vcunat merged commit 892c418 into NixOS:master Mar 29, 2017
@vcunat
Copy link
Member

vcunat commented Mar 29, 2017

17.03 doesn't need this change, apparently.

@makefu
Copy link
Contributor Author

makefu commented Mar 29, 2017

@vcunat because it is only a couple of explicit includes it will not kill the build with old cups.
Apparently there are more printer drivers which stop building, e.g. hplip (hear-say in IRC) .
/cc @Mic92

@vcunat
Copy link
Member

vcunat commented Mar 29, 2017

Master does have new cups; only some aspects of cups-config are broken.

@makefu
Copy link
Contributor Author

makefu commented Mar 29, 2017

I've got a response for my Support Request, apparently it is in the pipeline towards the dev team. In addition to that i've create a comment (as suggested by support) at http://developers.dymo.com/2012/02/21/announcing-dymo-labelwriterlabelmanager-sdk-1-4-0-for-linux/ (pending moderator approval)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants