[ci fw-only Go/revel] Repair revel tests, make future failures less punishing #2625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of function/property names have changed in the revel framework, causing our test code to not compile. I updated our code to use the new names.
Also, the fact that
setup.sh
was doing compilation in the background meant the failures went unnoticed by our toolset (specifically byframework_test.py
), causing a long period of inactivity in the test suite. Removing the&
fixes that problem, which will be useful in case the revel framework ever changes in a way that breaks our test code again.There are more details in the commit messages.