gnupg*: Improve the meta set #24390
Merged
gnupg*: Improve the meta set #24390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @urkud, @wkennington and @oxij to be potential reviewers. |
primeos
added a commit
to primeos/nixpkgs
that referenced
this pull request
Mar 27, 2017
All 20 tests did fail because no gpg binary was found. With gnupg1 as build input they never finish. Deactivating them might be the best option for now (and it improves the current situation since they never actually succeeded anyway -> build was failing, I noticed this while running nox-review for NixOS#24390).
|
LGTM. The `man` idea seems GTM too.
|
And use version from gnupg21 for gnupg1compat.
|
@peti @oxij Thanks for your feedback 😄 The other stuff will go into a separate commit (not sure about the name yet and I wonder if it would make sense to provide the gpg/gpgv symbolic links by default (because other distributions do and AFAIK some users don't know about gnupg1(compat) and the name is imho misleading, but there might be a reason for this decision)). Feel free if you want to share your opinion and/or implement this if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I thought having more consistent meta sets wold be a good idea (but especially
longDescriptionis a bit redundant now...) and I tried to improve some stuff (https, description and longDescription) - what do you think?I also noticed that gnupg1compat doesn't provide manual pages for gpg and gpgv (i.e. one has to use "man gpg2" or "man gpgv2" instead). This isn't a big problem but imho it would be nice if we could include symbolic links for that as well (and other distributions are doing that as well). But with the current approach this would probably be a bit hacky (due to the folder structure). Would it be a good idea to include an "use-flag" for this? Something like
compat(but that's actually a bad name in this case as it could be a package - any ideas for a better name? (e.g.legacySymlinksgpgSymlink, ...) and use the following expression in pkgs/top-level/all-packages.nix:And simply create the links in the
postInstallphase. And I assume we can keep the currentnameanddescriptionas well with the help of an if statement (depending on compat).And for what it's worth I think we should do the same for
gnupg20(but probably without the additional attribute name).cc @wkennington @peti @fpletz @vrthra @roconnor
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)