Handle link://category with an error #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2726. |
|
Add the new work e-mail address you used for this commit to your GitHub profile so your commits will appear as yours. |
Kwpolska
reviewed
Apr 19, 2017
| @@ -116,6 +116,9 @@ def slugify_tag_name(self, name, lang): | |||
|
|
|||
| def slugify_category_name(self, path, lang): | |||
| """Slugify a category name.""" | |||
| if not path: # Probably used link://category | |||
| utils.LOGGER.error('Invalid link to a category without passing a category name. Probably meant to use category_index?') | |||
| raise ValueError() | |||
There was a problem hiding this comment.
Perhaps we could give this exception meaningful content as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Fixes #2726.