Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydot: 1.0.2 -> 1.2.3 #25027

Merged
merged 1 commit into from May 1, 2017
Merged

pydot: 1.0.2 -> 1.2.3 #25027

merged 1 commit into from May 1, 2017

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

new version for pydot: 1.0.2 was broken for quite a few years, and development moved to GitHub. Built on Fedora, didn't extensively test it though.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@armijnhemel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@7c6f434c 7c6f434c merged commit 8295ecf into NixOS:master May 1, 2017
@FRidh
Copy link
Member

FRidh commented May 3, 2017

This commit was incomplete
https://headcounter.org/hydra/build/1802595/nixlog/1/raw

fixed in 97630b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants