Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PostgreSQL port in development #266

Merged
merged 1 commit into from Apr 24, 2017
Merged

Expose PostgreSQL port in development #266

merged 1 commit into from Apr 24, 2017

Conversation

gentlecat
Copy link
Contributor

No description provided.

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit such tiny changes directly -- I trust you to do the right thing.

@gentlecat
Copy link
Contributor Author

I'd prefer to still make PRs even if it might be a small change. I want to make sure that tests still pass in Jenkins, and maybe someone would have input on any kinds of changes. Everyone makes mistakes and there are always improvements to be had. Not necessary to review everything, I understand we don't have enough people.

@gentlecat gentlecat merged commit 0eedce1 into metabrainz:master Apr 24, 2017
@gentlecat gentlecat deleted the pg-port branch April 24, 2017 10:51
@mayhem
Copy link
Member

mayhem commented Apr 24, 2017

Got it. In this case, can you mark the reviews that don't strictly need reviews as such?

@gentlecat
Copy link
Contributor Author

gentlecat commented Apr 24, 2017

Sure, we can come up with some kind of label like minor-change and put it on less important PRs. I also usually explicitly assign reviewers when review is needed.

@mayhem
Copy link
Member

mayhem commented Apr 24, 2017

Good to know, and I think I'd also like the minor-change label, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants