Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-7_x: 7.7.3 -> 7.9.0 #25022

Closed
wants to merge 1 commit into from
Closed

nodejs-7_x: 7.7.3 -> 7.9.0 #25022

wants to merge 1 commit into from

Conversation

frankbo
Copy link
Contributor

@frankbo frankbo commented Apr 19, 2017

Motivation for this change

Nodejs update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@frankbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cko to be a potential reviewer.

@lo1tuma
Copy link
Member

lo1tuma commented Apr 20, 2017 •
edited

Duplicate of #25008.

@cko
Copy link
Member

cko commented Apr 20, 2017 •
edited

@svanderburg @grahamc @FRidh @Profpatsch would be totally cool if someone of you could merge it before we create even more duplicates 😄

@FRidh
Copy link
Member

FRidh commented Apr 20, 2017

merged the other

@FRidh FRidh closed this Apr 20, 2017
@cko
Copy link
Member

cko commented Apr 20, 2017

thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frankbo @mention-bot @lo1tuma @cko @FRidh @Janik-Haag