Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: Correct dependencies for haskell-tools-*_0_6_0_0 #24743

Merged
merged 1 commit into from Apr 9, 2017

Conversation

ljli
Copy link
Contributor

@ljli ljli commented Apr 8, 2017

If someone knows how to make it less verbose, please comment.
Tested haskell-tools-daemon_0_6_0_0 and haskell-tools-cli_0_6_0_0 binaries.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ljli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bennofs, @mdorman and @vcunat to be potential reviewers.

@bennofs
Copy link
Contributor

bennofs commented Apr 8, 2017

These changes should be in configuration-common, not configuration-nix

@ljli
Copy link
Contributor Author

ljli commented Apr 8, 2017

That's where I had them initially, but this is really a nix failure, the cabal files clearly state that 0.6.0.0 of all the packages are needed. But I guess that applies to many of the overrides in configuration-common and above. Updated incoming.

@bennofs
Copy link
Contributor

bennofs commented Apr 9, 2017

That is a good point. In general though, configuration-nix is really for things like native dependencies that aren't found without help etc and not for changing how the set of haskell packages is composed.

I wonder if cabal2nix / hackage2nix could do a better job here though. I will investigate this later. It feels hard though, as the whole package set must be coherent so hackage2nix cannot just let a single binary use a different version. It could do it for executables though, but then it would have to generate an overrideScope for executables which sounds hard.

Anyway, thanks very much for the PR!

@bennofs bennofs merged commit 8130c35 into NixOS:master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants