hy: Fix build inputs #24747
Merged
hy: Fix build inputs #24747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appdirs needs to be in `propogatedBuildInputs` for hy to run
Mic92
reviewed
Apr 8, 2017
| @@ -9,8 +9,7 @@ pythonPackages.buildPythonApplication rec { | |||
| sha256 = "1msqv747iz12r73mz4qvsmlwkddwjvrahlrk7ysrcz07h7dsscxs"; | |||
| }; | |||
|
|
|||
| buildInputs = [ pythonPackages.appdirs ]; | |||
| propagatedBuildInputs = [ pythonPackages.clint pythonPackages.astor pythonPackages.rply ]; | |||
| propagatedBuildInputs = with pythonPacckages; [ appdirs clint astor rply ]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appdirs needs to be in
propogatedBuildInputsfor hy to runMotivation for this change
When updating hy to 0.12.1 in #24735 I realized that appdirs needed to be in propogatedBuildInputs for this package to work. In its current state it is broken. This pull request is to fix the inputs without updating to a new version.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)