Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark linux-only pkgs #24760

Merged
merged 12 commits into from Apr 9, 2017
Merged

Mark linux-only pkgs #24760

merged 12 commits into from Apr 9, 2017

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Apr 9, 2017

Motivation for this change

All of these packages were broken on Darwin and probably won't ever work without huge changes in codebases.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @peti and @urkud to be potential reviewers.

@peti peti merged commit 4e307b6 into NixOS:master Apr 9, 2017
@matthewbauer matthewbauer deleted the linux-only-pkgs branch February 22, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants