Reuse parts from base path fingerprint. #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
See my comments just seconds ago... |
|
Does anything need to change on this? |
|
That referred to this comment: #297 (review) I don't have a particular request and if you don't either, after taking into account that comment, then I should apply this patch... (so, thanks for the ping :) |
|
We could make it extend the base Fingerprinter rather then duplicate but it's okay as it is. |
|
Actually it already extends it... give me two seconds and I'll delete the unnecessary code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked through derived classes - the only one that needed updating was the hybridisation fp.