deepin-terminal: Init at 2.3.3 #24768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snyh
force-pushed
the
deepin-terminal
branch
2 times, most recently
from
1dfc86b
to
5358cd1
Compare
joachifm
reviewed
Apr 9, 2017
| patchPhase = '' | ||
| substituteInPlace project_path.c --replace __FILE__ \"$out/share/deepin-terminal/\" | ||
| ''; | ||
| buildInputs = [ unzip gtk3 pkgconfig bash vala cmake vte gee wnck gettext libsecret json_glib ]; |
There was a problem hiding this comment.
bash should be redundant; it's already in the standard environment.
joachifm
reviewed
Apr 9, 2017
| meta = { | ||
| description = "The default terminal emulation for Deepin"; | ||
| longDescription = '' | ||
| Deepin terminal, it sharpens your focus in the world of command line! |
There was a problem hiding this comment.
Would you mind indenting this as in
longDescription = ''
lorem ipsum
foo bar
'';
for the sake of consistency.
joachifm
reviewed
Apr 9, 2017
| longDescription = '' | ||
| Deepin terminal, it sharpens your focus in the world of command line! | ||
| Deepin Terminal is an advanced terminal emulator with workspace, multiple windows, remote management, quake mode and other features. | ||
| It sharpens your focus in the world of command line! |
There was a problem hiding this comment.
This phrase is repeated.
|
Looks pretty good to me, added a few minor points for you to consider. |
joachifm
reviewed
Apr 9, 2017
| src = fetchFromGitHub { | ||
| owner = "linuxdeepin"; | ||
| repo = "deepin-terminal"; | ||
| rev = "${version}"; |
There was a problem hiding this comment.
Strictly speaking, you can do rev = version here.
|
@joachifm thanks your help. I have adjusted the PR |
|
@joachifm Can we merge this? By the way, how can I mirror the cache.nixos.org ? I have seen someone say using |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the deepin-terminal which is a friendly terminal emulator .
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)