New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin: miscellaneous fixes #24762
darwin: miscellaneous fixes #24762
Conversation
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ndowens, @vcunat and @acowley to be potential reviewers. |
I get this when building cwebbin, do you get the same with
|
I uploaded a fix. |
Oh it's actually |
@LnL7 Ok got it now, I think. How do you feel about these kind of "miscellaneous" pull requests? I can definitely open separate PRs for each commit but these are mostly unused, tiny packages that I think can be grouped together. |
I don't have a problem with it for trivial changes like this. It's just generally preferred to keep unrelated changes separate to reduce the chance of good changes getting blocked by another issue or unrelated merge conflicts. |
Motivation for this change
This is a bunch of miscellaneous fixes to Darwin. I can split them up into multiple prs if necessary, but hopefully it won't be necessary.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)