lambda-mod-zsh-theme: init at eceee68cf46bba9f7f42887c2128b48e8861e31b #24479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's possible to set the path of this derivation as `ZSH_CUSTOM` in the zsh configuration, so it's possible to use the theme directly from the store path. see https://github.com/robbyrussell/oh-my-zsh/wiki/Customization#overriding-and-adding-themes
|
rebased onto current master and modified the behavior to make it possible to use Am I missing something or is this ready to be merged after that? |
|
This looks good to me, thank you! If anything should go bad, we can still change this later. |
|
cool, thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
lambda-mod-zsh-themeis a simple ZSH theme I currently use on my laptop.As I currently switch to a nix-based setup for ZSH, I need a nix package for that.
(see https://github.com/halfo/lambda-mod-zsh-theme/ and https://github.com/halfo/lambda-mod-zsh-theme/blob/master/LICENSE for License information)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)