New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICARD-1041: Replace Ok button text by Make It So! in Options dialog #668
Conversation
@@ -84,7 +84,9 @@ def __init__(self, default_page=None, parent=None): | |||
self.ui.reset_button = QtGui.QPushButton(_("Restore &Defaults")) | |||
self.ui.reset_button.setToolTip(_("Reset all settings for current option page")) | |||
|
|||
self.ui.buttonbox.addButton(StandardButton(StandardButton.OK), QtGui.QDialogButtonBox.AcceptRole) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# April fool
self.ui.buttonbox.addButton(StandardButton(StandardButton.OK).setText(_("Make It So!")), QtGui.QDialogButtonBox.AcceptRole)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sophist-UK : it's not an April fool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. :-)
I have to admit that I don't like this. It's bad enough to make one of the most important buttons of the whole application an easter egg that not everybody might get, but this is not even translated in a single language. I'm sorry, but do we expect everybody using any of the enabled languages in picard to get english star trek references? |
Admittedly it is a bit geeky - ok, a lot geeky - and of course, @mineo's common sense should prevail. But I hope it doesn't - a little quirkiness and individuality is becoming a rarity these days. Of course, @mineo can always submit translations so that "Make it so" translates to OK in every language other than English. ;-) |
P.S. Should |
I could, but would already fail at providing one for my native language german because AFAIK "Make it so" is not Picards catch-phrase in german and doesn't have a consistent translation across all episodes. |
Thinking again about this - how about the button text being "OK, Make it so" as a compromise - because some people won't get the reference and will wonder where the OK button is. |
https://tickets.metabrainz.org/browse/PICARD-1041