Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boomerang: update to latest git, un-mark broken #24475

Merged
merged 1 commit into from May 1, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 30, 2017

  • Now with Qt UI
  • Rework kludges to help boomerang find itself
  • update/rework cmake bits for installation
  • Fix output directory path defaults
Motivation for this change

Saw boomerang marked broken (and it sure was!), thought I'd take a crack at fixing it :).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

* Now with Qt UI
* Rework kludges to help boomerang find itself
* update/rework cmake bits for installation
* Fix output directory path defaults
@mention-bot
Copy link

@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @globin and @dezgeg to be potential reviewers.

@7c6f434c 7c6f434c merged commit 698141a into NixOS:master May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants