wrk: use packaged openssl, luajit #24481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the side effect of now building on darwin. Previously, the
vendored luajit would fail to build.
Motivation for this change
Want to build on darwin. Also using the nixpkgs luajit and openssl rather than the vendored copies included in wrk (the vendored luajit failed to compile on darwin).
Note I included
luajit
in the function arguments, rather thanlua
combined with alua = luajit
in thecallPackage
because this package will only work withluajit
and not other implementations. Happy to change that if that's the wrong style.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)