DO NOT MERGE - Mac smart mining #1936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whoo, something compiled, if someone wants to build the branch on their mac and let me know if it actually runs that'd be awesome. |
|
I can give it a shot later today |
|
Doesn't seem to work https://paste.fedoraproject.org/paste/p9u0RCR3Kv858fUlknNM1V5M1UNdIGYhyRLivL9gydE= |
|
Can you try with the last parameter set to true (ignores power requirements
if it fails to query)?
…On Tue, Mar 28, 2017, 9:06 PM xmr-eric ***@***.***> wrote:
Doesn't seem to work
https://paste.fedoraproject.org/paste/p9u0RCR3Kv858fUlknNM1V5M1UNdIGYhyRLivL9gydE=
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1936 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0DGuBStNG24MyAplTfmqPD4DnGMv86ks5rqa56gaJpZM4MrBnl>
.
|
|
The fpaste shows me trying it with the last parameter set both to true and false. See line 11 and 20. |
|
@revler1082 is this still WIP and must stay open? |
|
Yea, I think I know what I have to do, just gotta find some time, I'll try
to get it done by this week or close the PR
…On Mon, Apr 10, 2017, 6:15 PM Riccardo Spagni ***@***.***> wrote:
@revler1082 <https://github.com/revler1082> is this still WIP and must
stay open?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1936 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0DGhQHDrLT6kZrexVcejokKX79Ic0Oks5ruqnkgaJpZM4MrBnl>
.
|
|
@revler1082 just giving this a little bump - no rush if you haven't gotten to it :) |
|
I've been ignoring this for no good reason - @revler1082 do you need a tester? I have a Mac Mini here that I could test against and debug on. |
|
Yea I don't have a Mac so I kinda just guessed, I think I got it right, but
I might just need to multiply/divide by 100 somewhere
…On Sun, May 28, 2017, 5:00 PM Lee Clagett ***@***.***> wrote:
I've been ignoring this for no good reason - @revler1082
<https://github.com/revler1082> do you need a tester? I have a Mac Mini
here that I could test against and debug on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1936 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0DGiFtGZfLu5qXkse-72IA1j8RsMyCks5r-eB1gaJpZM4MrBnl>
.
|
|
Ok waiting on feedback from @vtnerd before merging |
ghost
mentioned this pull request
|
@revler1082 @fluffypony @vtnerd Should this be closed in favour of #2055? |
|
Yea if he made it work on Mac go for it
…On Fri, Jun 30, 2017, 9:42 AM Nano Akron ***@***.***> wrote:
Should this be closed in favour of #2055
<#2055>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1936 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0DGq2Jtse5CuuOvdU9RDMgg9dzI4Vcks5sJPstgaJpZM4MrBnl>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just abusing the CI to see if this will compile since I don't have a mach, don't hate me =(