-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AARCH64 support in FFI #4548
Conversation
@ayappanec Is this patch ok to be merged for support for AArch64? |
The PR looks good. |
@headius Could you please check it? Thanks! |
@@ -84,6 +84,7 @@ | |||
SPARCV9, | |||
S390X, | |||
ARM, | |||
AARCH64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tab, use spaces instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting !. How did you figured this out ? by seeing the indentation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The presentation was 1 character off in this view.
Then: Visiting "View", marking and dragging the cursor over and seeing that the visualization of the marked text "snapped" to a tab stop, not to individual spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool. Thanks for the info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olleolleolle It's awesome! Thanks!
@enebo Could you please take your time to review this changes? Thanks! |
Hello! Sorry this slipped a bit. Looking into merging. |
This PR is to add support for the AARCH64/ARM64 in JRuby FFI.