Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AARCH64 support in FFI #4548

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Add AARCH64 support in FFI #4548

merged 2 commits into from
Apr 19, 2017

Conversation

yuqilinaro
Copy link
Contributor

This PR is to add support for the AARCH64/ARM64 in JRuby FFI.

@yuqilinaro
Copy link
Contributor Author

@ayappanec Is this patch ok to be merged for support for AArch64?
Could you please review it? thanks a lot!

@ayappanec
Copy link

The PR looks good.

@yuqilinaro
Copy link
Contributor Author

@headius Could you please check it? Thanks!

@@ -84,6 +84,7 @@
SPARCV9,
S390X,
ARM,
AARCH64,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tab, use spaces instead.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting !. How did you figured this out ? by seeing the indentation ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The presentation was 1 character off in this view.

Then: Visiting "View", marking and dragging the cursor over and seeing that the visualization of the marked text "snapped" to a tab stop, not to individual spaces.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. Thanks for the info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olleolleolle It's awesome! Thanks!

@guyuqi
Copy link
Contributor

guyuqi commented Apr 10, 2017

@enebo Could you please take your time to review this changes? Thanks!

@headius
Copy link
Member

headius commented Apr 19, 2017

Hello! Sorry this slipped a bit. Looking into merging.

@headius headius added this to the JRuby 9.1.9.0 milestone Apr 19, 2017
@headius headius merged commit e06bd07 into jruby:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants